Fix ErrorHandler's Max Fail time #4771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase maxFailTime so the jobs are not mistakenly exhausted by ErrorHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ErrorHandler.maxFailTime sets a maximum time a job can run to be retried. If a job takes longer than
maxFailTime, it does not go to the retry logic and it is failed immediately.This allows regular production agents to avoid retrying long executing jobs. Nonetheless, T0 never wants to skip the retry logic, as we want to be able to recover jobs using the PauseAlgo plugin.
The current configuration of
maxFailTime=12000(33.3h) means that if a job fails after this long, it is directly exhausted and doesn't go to the usual pause state, causing issues like the one described here:https://cms-talk.web.cern.ch/t/summary-of-failures-in-promptreco-jobs/16373/5
Here we are setting
maxFailTime=601200(167h), effectively disabling this feature for T0 agents.