Update 00_deploy_replay.sh to prevent deployments on production nodes #4819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
germanfgv
reviewed
May 10, 2023
Contributor
germanfgv
left a comment
There was a problem hiding this comment.
Looks ok, a few tweaks should be enough
germanfgv
reviewed
May 11, 2023
bin/00_deploy_replay.sh
Outdated
| @@ -1,4 +1,29 @@ | |||
| #!/bin/bash | |||
| confirm_deploy="" | |||
| replay_nodes=("vocms0500.cern.ch" "vocms047.cern.ch" "vocms001.cern.ch" "C4_vocms047.cern.ch") | |||
Contributor
There was a problem hiding this comment.
remove Cx_vocms047. That's not a real VM.
germanfgv
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Deployment Script
Requestor Antonio Linares
Team or person that requests this replay
Purpose of the Update
Updated 00_deploy_replay.sh to ask for confirmation before deploying on a production node.