Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Era by run #5026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeyserma merged 6 commits into from
Jun 23, 2025
Merged

Era by run #5026

jeyserma merged 6 commits into from
Jun 23, 2025

Conversation

@LinaresToine
Copy link
Contributor

@LinaresToine LinaresToine commented Nov 22, 2024

Proposal to change era after a specified run value.

@LinaresToine LinaresToine force-pushed the era_by_run branch 6 times, most recently from 5414b15 to dfbc29f Compare November 23, 2024 01:01
@LinaresToine
Copy link
Contributor Author

LinaresToine commented Nov 23, 2024 •
edited
Loading

Deployed a replay with this patch and runs 380128, 382686, 386925. See ReplayOfflineConfiguration.py

Era Tier0_REPLAY_2024A is set to change to Tier0_REPLAY_2024B at run 382686 with parameter maxRunOldEra
The workflows have been created properly, with runs 380128, 382686 part of era Tier0_REPLAY_2024A and run 386925 part of Tier0_REPLAY_2024B

@germanfgv @jeyserma what do you guys think of this solution?

@LinaresToine LinaresToine force-pushed the era_by_run branch 5 times, most recently from 95d6866 to 6000877 Compare November 23, 2024 01:57
@LinaresToine LinaresToine force-pushed the era_by_run branch 2 times, most recently from be23ddf to 21cd35a Compare June 12, 2025 00:46
@LinaresToine
Copy link
Contributor Author

LinaresToine commented Jun 12, 2025

Hello @jeyserma this patch has correctly changed era provided a specific limit run. Could you please have a look at the code?

@LinaresToine LinaresToine requested a review from jeyserma June 12, 2025 08:24
jeyserma
jeyserma reviewed Jun 16, 2025
View reviewed changes
src/python/T0/RunConfig/RunConfigAPI.py Outdated
thresholdRuns = list(tier0Config.Global.AcquisitionEra['maxRun'])
caseRun = max(thresholdRuns)

if run <= caseRun:
Copy link
Contributor

@jeyserma jeyserma Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caseRun is not defined when maxRun is not defined. I suggest setting a default for caseRun to 999999; or take the default acquisition era when maxRun does not exist.

@jeyserma
Copy link
Contributor

jeyserma commented Jun 16, 2025

Thanks Antonio. Apart from 1 comment, the PR looks good to me. Can you also add in the prod/replay some comments on how it should be used? I.e., you can only append new ERAs, and the one with the maximum run will be taken into account; the rests gets ignored but kept for bookkeeping reasons.

I also think it will affect ERA extraction on the nodeSummary page?

@LinaresToine LinaresToine force-pushed the era_by_run branch 2 times, most recently from 6df6881 to 71ffd88 Compare June 20, 2025 10:37
@LinaresToine
Copy link
Contributor Author

LinaresToine commented Jun 20, 2025

Hello @jeyserma I have updated the changes and tested them successfully. Please review and merge when ready

@LinaresToine LinaresToine mentioned this pull request Jun 20, 2025
Merged
@jeyserma
Copy link
Contributor

jeyserma commented Jun 23, 2025

Looks good, merging now

@jeyserma jeyserma merged commit 9871e1f into master Jun 23, 2025
1 check passed
@LinaresToine LinaresToine mentioned this pull request Jul 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeyserma jeyserma jeyserma left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LinaresToine @jeyserma