Replace Oracle SEQUENCE constraints used by GENERATE auto-increment #5079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @LinaresToine , as we have just merged these changes in WMCore dmwm/WMCore#12341, can you please merge this PR as well? If you prefer, please let me know and I can squash these commits. |
Contributor
Author
|
test this please |
Contributor
|
Thanks a lot Alan, everything looks ok. I am merging now |
This was referenced Jul 22, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the SQL database schema isolation and streamline, proposed in dmwm/WMCore#12341, we need to stop using Oracle SEQUENCE constraints within the Tier0 CRUD SQL statements, as columns are now defined with the auto-increment
GENERATED BY DEFAULT AS IDENTITYclause.When executing a replay to test all this SQL schema separation, we need to change the T0 agent deployment to consider:
@LinaresToine the only difference from what we have already been doing is this patch. Can you please apply it to that replay test that you started last week? Or just start a new deployment and ensure that the agent is patched with this PR. Thank you in advance!