Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@samircury
Copy link
Member

Title says pretty much what it is, test works for me.

@hufnagel
Copy link
Member

hufnagel commented Aug 7, 2012

Is this fixing #3954 ?

@samircury
Copy link
Member Author

It does. Close it too if you want.

@hufnagel
Copy link
Member

hufnagel commented Aug 9, 2012

Next time mention that in the pull request title and add "fixes #3954". Issues referenced this way are closed automatically. I'll change it for this one.

@hufnagel
Copy link
Member

hufnagel commented Aug 9, 2012

Functional, but some coding style issues that affect code readability. Might as well test the procedure how to add commits to pull request and whether or not we can squash commits in existing pull requests (not sure about that...)

Now the comments:

  1. If you call DAOs in different methods, you usually only create the DAOFactory once and from there you can either keep the DAOFactory as a class variable and reuse it in the methods or you create the DAO references in the class init and keep them as class variables. Either is fine, but we should not mix as it makes the code harder to read. The existing unit test used the later method, your changes uses the former. Should be changed.
  2. The DAOFactory import is unused and should be removed
  3. self.insertWorkflowMonitoringDAO is not used and should be removed

@ghost ghost assigned samircury Aug 9, 2012
@samircury
Copy link
Member Author

About the test, might not work, and makes sense to me, here's what I did in this order (not the best, I know) :

  • Outdated repository, made the changes and commited locally
  • git pull to upmaster, merged with local dev-branch
  • Squashed the new patch with the old one
  • Tried git push, got :

[lxplus425] /afs/cern.ch/user/s/samir/private/t0/git/T0 > git push
Counting objects: 66, done.
Delta compression using up to 16 threads.
Compressing objects: 100% (42/42), done.
Writing objects: 100% (45/45), 6.09 KiB, done.
Total 45 (delta 25), reused 0 (delta 0)
To https://github.com/samircury/T0.git
8723701..80afc52 master -> master
! [rejected] gmt0-small-corrections -> gmt0-small-corrections (non-fast-forward)
error: failed to push some refs to 'https://github.com/samircury/T0.git'
To prevent you from losing history, non-fast-forward updates were rejected
Merge the remote changes (e.g. 'git pull') before pushing again. See the
'Note about fast-forwards' section of 'git push --help' for details.

As this time I just want to get the code through, I'm creating another branch, then another pull request with all the changes integrated and this pull request can be ignored and closed.

hufnagel added a commit that referenced this pull request Aug 29, 2012
unit test for T0Feeder - injects a workflow to couch to make sure it works, fixes #3954
@hufnagel hufnagel merged commit dc8e45a into dmwm:master Aug 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants