Thanks to visit codestin.com
Credit goes to github.com

Skip to content

implement PCL condition upload functionality #3974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hufnagel merged 1 commit into from
Sep 25, 2012
Merged

implement PCL condition upload functionality #3974

hufnagel merged 1 commit into from
Sep 25, 2012

Conversation

@hufnagel
Copy link
Member

@hufnagel hufnagel commented Sep 22, 2012

Add everything needed to upload the PCL conditions produced by the AlcaHarvest to the DropBox.

@hufnagel
Copy link
Member Author

hufnagel commented Sep 22, 2012

@dballesteros7 , can you test this and check that the usual unit tests still work ?

@dballesteros7
Copy link
Contributor

dballesteros7 commented Sep 24, 2012

All tests but one work. T0_t/WMBS_t/JobSplitting_t/Condition_t.py fails with:


======================================================================
ERROR: _test00_
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/testEnv/test-T0/test/python/T0_t/WMBS_t/JobSplitting_t/Condition_t.py", line 173, in test00
    jobGroups = jobFactory(**mySplitArgs)
  File "/testEnv/cms-comp/slc5_amd64_gcc461/cms/wmagent/0.9.18/lib/python2.6/site-packages/WMCore/JobSplitting/JobFactory.py", line 89, in __call__
    self.algorithm(*args, **kwargs)
  File "/testEnv/test-T0/src/python/T0/JobSplitting/Condition.py", line 37, in algorithm
    runNumber = kwargs['runNumber']
KeyError: "'runNumber'
-------------------- >> begin captured logging << --------------------
root: DEBUG: Using SQLAlchemy v.0.5.2
root: INFO: Instantiating base WM DBInterface
root: DEBUG: Tables for WMCore.WMBS created
root: DEBUG: Tables for T0.WMBS created
--------------------- >> end captured logging << ---------------------"
----------------------------------------------------------------------

@hufnagel
implement PCL condition upload functionality
83daead 
Add everything needed to upload the PCL conditions
produced by the AlcaHarvest to the DropBox.
@hufnagel
Copy link
Member Author

hufnagel commented Sep 25, 2012

Ok, the unit test was old and did not test the new system behavior (there was a design change in that part). I fixed the unit test and the new unit test then found a bug in the Condition job splitter, so I fixed that as well.

@dballesteros7
Copy link
Contributor

dballesteros7 commented Sep 25, 2012

Test works for me now.

hufnagel added a commit that referenced this pull request Sep 25, 2012
@hufnagel
Merge pull request #3974 from hufnagel/sqliteupload
3ed3a43 
implement PCL condition upload functionality
@hufnagel hufnagel merged commit 3ed3a43 into dmwm:master Sep 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hufnagel @dballesteros7