fix bug in the prompt calibration loop #3986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two types of bugs in the PCL. We passed a stream id instead of a stream name to a call. Plus a logic bug that prevented this call from being made in almost all cases (this is how it slipped through testing). Put in a temporary fix that will restore upload functionality, but isn't final yes.
hufnagel
added a commit
that referenced
this pull request
Oct 4, 2012
fix bug in the prompt calibration loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two types of bugs in the PCL. We passed a stream id instead of a stream name to a call. Plus there was a logic bug that prevented this call from being made in almost all cases (this is how it slipped through testing). Put in a temporary fix that will restore upload functionality, but isn't final yes.