Uniformize Attribute Group Usage #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #207 +/- ##
==========================================
- Coverage 72.3% 70.25% -2.06%
==========================================
Files 218 218
Lines 3723 3927 +204
==========================================
+ Hits 2692 2759 +67
- Misses 1031 1168 +137
Continue to review full report at Codecov.
|
DJBen
approved these changes
Nov 19, 2019
jsbean
reviewed
Nov 19, 2019
| style: ArrowStyle? = nil, | ||
| position: Position? = nil, | ||
| printStyle: PrintStyle? = nil, | ||
| position: Position = Position(), |
|
This is excellent, @bwetherfield. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attribute groups are labeled
: AttributeGroupinternally, and are non-Optional when appearing as attribute group values.