Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Full-text Search #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 19, 2020
Merged

Full-text Search #19

merged 6 commits into from
Oct 19, 2020

Conversation

@jesselang
Copy link
Contributor

Description

Added full-text search option for header, method, and status references.

Fixes #13

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

A single primitive unit test of the search function. If you have some specific cases you'd like covered, let me know.

  • Running existing tests
  • Created new tests

Checklist:

  • My code has been linted (make lint)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have rebased my branch to include the latest changes from master

dnnrly
dnnrly reviewed Oct 17, 2020
View reviewed changes
@dnnrly
Copy link
Owner

dnnrly commented Oct 17, 2020

Can you add a new test case to acceptance.bats? This will allow us to prove the plumbing still works in future tests.

Otherwise, very good contribution!

@jesselang
Copy link
Contributor Author

I've added some cases to basic.bats. Let me know how that strikes you. 😄

@jesselang jesselang requested a review from dnnrly October 19, 2020 00:48
@dnnrly
Copy link
Owner

dnnrly commented Oct 19, 2020

Yup, this is all good!

@dnnrly dnnrly merged commit cd6f3ca into dnnrly:master Oct 19, 2020
@jesselang jesselang mentioned this pull request Oct 22, 2020
Merged
@jesselang
Copy link
Contributor Author

Hey @dnnrly, would you be willing to label this PR as hacktoberfest-accepted? Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dnnrly dnnrly Awaiting requested review from dnnrly

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add free text search

2 participants

@jesselang @dnnrly