This repository was archived by the owner on Sep 1, 2022. It is now read-only.
Added extra log when closing a new connection based on ServerAcceptMode::CloseNew
#442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode::CloseNew`. Fix #421.
Codecov Report
@@ Coverage Diff @@
## develop #442 +/- ##
===========================================
- Coverage 51.36% 51.34% -0.03%
===========================================
Files 423 423
Lines 13444 13445 +1
===========================================
- Hits 6906 6903 -3
- Misses 6538 6542 +4
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ServerAcceptMode::CloseNewworks as expected. However, in the logs, it shows that it accepts the connection but doesn't tell that it is immediately shutdown. I added a log statement to make it clear.Fix #421.