Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Separate all CROB fields instead of having a giant enum. #349

Merged
emgre merged 2 commits into from
Apr 17, 2020
Merged

Separate all CROB fields instead of having a giant enum. #349

emgre merged 2 commits into from
Apr 17, 2020

Conversation

@emgre
Copy link
Member

@emgre emgre commented Jan 17, 2020 •
edited
Loading

Closes #324.

  • ControlRelayOutputBlock is now made of a OperationType, a TripCloseCode and a clear flag instead of a giant enum.
  • The first constructor takes each parameter (with defaults for each of them), the second taks a raw command code (if someone wants to use an undefined code or set the QU bit)
  • If the outstation receives a command with the QU bit set, it automatically responds with NOT_SUPPORTED without even calling the command handler. A unit test was written for this.
  • The Java and C# bindings were updated accordingly.
  • The Java now has an extensive integration test for sending/receiving commands between to stacks.

The CircleCI currently fails because we ran out of credits. I'm in touch with them to get the full 100,000 credits/week we are entitled for instead of the current 2,500 credits/week (which gets exhausted very quickly with the Windows builds). Apparently it doesn't apply to the Windows compute time. Anyways, we are now using GitHub Actions so 💁🏻‍♂️

@emgre emgre force-pushed the feature/crob-separation branch from 8474e19 to 918092d Compare April 17, 2020 14:49
@codecov
Copy link

codecov bot commented Apr 17, 2020 •
edited
Loading

Codecov Report

Merging #349 into develop will increase coverage by 0.14%.
The diff coverage is 31.53%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #349      +/-   ##
===========================================
+ Coverage    46.82%   46.97%   +0.14%     
===========================================
  Files          501      502       +1     
  Lines        15589    15578      -11     
===========================================
+ Hits          7300     7318      +18     
+ Misses        8289     8260      -29
Impacted Files Coverage Δ
...lib/include/opendnp3/app/ControlRelayOutputBlock.h 0.00% <0.00%> (ø)
cpp/lib/src/app/MeasurementFactory.h 60.71% <ø> (ø)
cpp/lib/src/decoder/LoggingHandler.cpp 0.00% <0.00%> (ø)
cpp/lib/src/gen/TripCloseCode.cpp 22.72% <22.72%> (ø)
cpp/lib/src/gen/OperationType.cpp 27.45% <27.45%> (ø)
cpp/lib/src/app/ControlRelayOutputBlock.cpp 100.00% <100.00%> (ø)
cpp/lib/src/outstation/CommandActionAdapter.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9872c21...1e1b45c. Read the comment docs.

@emgre emgre force-pushed the feature/crob-separation branch 3 times, most recently from 06bec27 to 69c16da Compare April 17, 2020 17:08
@emgre emgre force-pushed the feature/crob-separation branch from 69c16da to 1e1b45c Compare April 17, 2020 17:25
@emgre emgre merged commit db3f9ec into develop Apr 17, 2020
@emgre emgre deleted the feature/crob-separation branch April 17, 2020 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emgre