Simplified Windows build fix + some modernization of CMakeBuild files #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 26, 2019 10:15
- Setting C++11 and other compiler options without directly using compiler flags. - Using a target based approach (instead of directory based) for setting include directories.
dnwrnr
requested changes
Jul 21, 2019
CMakeLists.txt
Outdated
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-long-long") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wcast-align") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wsign-conversion") | ||
| if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU") |
libsgp4/CMakeLists.txt
Outdated
| install( TARGETS sgp4s LIBRARY DESTINATION lib ) | ||
| if(WIN32) | ||
| install(TARGETS sgp4s | ||
| RUNTIME DESTINATION lib) |
There was a problem hiding this comment.
Can you explain why the library requires the runtime location specified?
dnwrnr
requested changes
Dec 7, 2019
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-long-long") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wcast-align") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wsign-conversion") | ||
| if(CMAKE_COMPILER_IS_GNUCC) |
There was a problem hiding this comment.
Again is this compatible with clang?
There was a problem hiding this comment.
Sorry, I forgot about this. I will try to motivate the change request in the following days. (Just to mention: I actually use my branch of your code in a ground segment tool for satellites that will launch during 2020.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows build fixes:
CMake modernization: