Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yadongli
Copy link
Contributor

all tests has passed, please review and merge.

@o314
Copy link

o314 commented Oct 5, 2018

It seems you need to generate a Project.toml file.
May be with a Test specific section.

More info here :

@takumorizo
Copy link

In your commit, at .travis.yml, Julia v0.6 is specified, and travis-ci log details show that julia v0.6.4 is used for Travis-CI build. That seems to generate errors in Travis-CI build.

@s-celles
Copy link

s-celles commented Oct 9, 2018

Thanks for your fix @yadongli

but I think you just need to change

DocOpt.jl/.travis.yml

Lines 4 to 5 in 5f5e12e

julia:
- 0.6

to

julia:
  - 0.7
  - 1.0
  - nightly
matrix:
    allow_failures:
        - julia: nightly

@yadongli
Copy link
Contributor Author

thanks for the pointers, i updated the .travis.yml and the CI test has passed,

@s-celles
Copy link

It will be nice if @bicycle1885 could merge this and publish a tag for this version because there is currently no published CLI argument parser library for Julia 0.7/1.0 (ArgParse.jl also need Julia 0.7/1.0 testing)

@s-celles
Copy link

Any news @bicycle1885 ?
Pinging also some members of https://github.com/docopt/ @keleshev @edwindj @shabbyrobe @BurntSushi if @bicycle1885 is too busy.

@s-celles
Copy link

@yadongli just a small Git/Github tip... when submitting a PR you should do it from an other branch than master (a julia_07_10 branch for example) because if upstream author decide not to merge your PR your master and upstream master won't be sync which is generally not a great idea.

@staticfloat
Copy link
Collaborator

If @bicycle1885 is too busy to maintain this package, I would be happy to help out. I know Kenta has not been very responsive on GitHub recently, so if we can spread out the maintenance burden a bit that might help everybody.

@s-celles
Copy link

@staticfloat That will be very nice if you could tackle this but one of members of docopt Github org should grant you collaborator access to this repository to speed up things.
Pinging @keleshev @edwindj @shabbyrobe @BurntSushi

@bicycle1885
Copy link
Member

Hi, I'm very sorry for not being responsive these days, and I think it will continue for a while. Fortunately, @staticfloat has volunteered to maintain this package and so I've added him as an admin. I'm going to get back soon or later but I think co-maintaining the package is a good idea. Thank you very much, @staticfloat!

@staticfloat
Copy link
Collaborator

Thanks Kenta, I know that life outside of Julia-land can become very busy at times. :)

I'm going to merge this and tag a new release. Thanks @yadongli for doing the work of upgrading the syntax.

@staticfloat staticfloat merged commit f956e63 into docopt:master Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants