Thanks to visit codestin.com
Credit goes to github.com

Skip to content

history: finalize when exporting #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

history: finalize when exporting #690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/buildx/history.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,11 @@ export class History {
return await this.exportLegacy(builderName, nodeName, refs, outDir, opts.image);
}

// wait 3 seconds to ensure build records are finalized: https://github.com/moby/buildkit/pull/5109
await Util.sleep(3);
if (await this.buildx.versionSatisfies('<0.24.0')) {
// wait 3 seconds to ensure build records are finalized: https://github.com/moby/buildkit/pull/5109
// not necessary since buildx 0.24.0: https://github.com/docker/buildx/pull/3152
await Util.sleep(3);
}

const summaries: Summaries = {};
if (!opts.noSummaries) {
Expand Down Expand Up @@ -139,7 +142,12 @@ export class History {

const dockerbuildPath = path.join(outDir, `${History.exportFilename(refs)}.dockerbuild`);

const cmd = await this.getExportCommand(['--builder', builderName, '--output', dockerbuildPath, ...refs]);
const exportArgs = ['--builder', builderName, '--output', dockerbuildPath, ...refs];
if (await this.buildx.versionSatisfies('>=0.24.0')) {
exportArgs.push('--finalize');
}

const cmd = await this.getExportCommand(exportArgs);
await Exec.getExecOutput(cmd.command, cmd.args);

const dockerbuildStats = fs.statSync(dockerbuildPath);
Expand Down
Loading