Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: bump to use node20 runtime, actions/checkout to v4 #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kbdharun wants to merge 1 commit into from
Closed

feat: bump to use node20 runtime, actions/checkout to v4 #590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Stop docker
run: |
Expand All @@ -39,7 +39,7 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Login to GitHub Container Registry
uses: ./
Expand All @@ -56,7 +56,7 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Login to GitHub Container Registry
uses: ./
Expand All @@ -81,7 +81,7 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Login to ACR
uses: ./
Expand All @@ -101,7 +101,7 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Login to Docker Hub
uses: ./
Expand All @@ -120,7 +120,7 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Login to ECR
uses: ./
Expand All @@ -140,7 +140,7 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v3
Expand All @@ -165,7 +165,7 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Login to Public ECR
uses: ./
Expand All @@ -187,7 +187,7 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v3
Expand All @@ -212,7 +212,7 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Login to GitHub Container Registry
uses: ./
Expand All @@ -232,7 +232,7 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Login to GitLab
uses: ./
Expand All @@ -252,7 +252,7 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Login to Google Artifact Registry
uses: ./
Expand All @@ -272,7 +272,7 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Login to Google Container Registry
uses: ./
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Test
uses: docker/bake-action@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Targets matrix
id: targets
Expand All @@ -33,7 +33,7 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Validate
uses: docker/bake-action@v3
Expand Down
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ inputs:
required: false

runs:
using: 'node16'
using: 'node20'
Copy link
Member

@crazy-max crazy-max Sep 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't just bump to node20, we also need to align dev dependencies and update our toolkit.

Also I don't know why GitHub made a such drastic bump and didn't update to the latest LTS node 18 instead: https://nodejs.dev/en/about/releases/

image

Some users already complain: actions/checkout@97a652b

Anyway I will look into it and keep you posted. Closing in the meantime but thanks for your input.

Copy link
Author

@kbdharun kbdharun Sep 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't just bump to node20, we also need to align dev dependencies and update our toolkit.

Noted, thanks. Feel free to close my other PRs too (if necessary).

Also I don't know why GitHub made a such drastic bump and didn't update to the latest LTS node

Same here

Copy link
Member

@crazy-max crazy-max Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi this is tracked here #593

main: 'dist/index.js'
post: 'dist/index.js'