Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@hyunnaye
Copy link
Contributor

@hyunnaye hyunnaye commented Apr 3, 2025

Description
This PR removes restub functionality in the UI

Before: (note the restub button)
image

After
image

Review Instructions
Verify the restub button no longer exists.

Issue
https://ucsc-cgl.atlassian.net/browse/DOCK-2585

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@hyunnaye hyunnaye self-assigned this Apr 3, 2025
@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.80%. Comparing base (7aca28a) to head (4b04d46).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2075      +/-   ##
===========================================
+ Coverage    41.78%   41.80%   +0.02%     
===========================================
  Files          390      390              
  Lines        12327    12321       -6     
  Branches      2947     2947              
===========================================
  Hits          5151     5151              
+ Misses        4873     4867       -6     
  Partials      2303     2303              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, merge conflict.

@sonarqubecloud
Copy link

@hyunnaye hyunnaye requested a review from denis-yuen April 14, 2025 21:18
@hyunnaye hyunnaye merged commit 63b8cc2 into develop Apr 15, 2025
19 of 20 checks passed
@hyunnaye hyunnaye deleted the feature/DOCK-2585 branch April 15, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants