Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Feb 9, 2024

Description
update dropwizard and it's supporting components to dropwizard 4.0.11
should resolve dependabot mdoerate severity PRs such as #6017 #6016 #6015
and unblock us from future dropwizard updates

Downside is I had to remove the restarting elastic search method from integration tests.
Can follow-up in https://ucsc-cgl.atlassian.net/browse/SEAB-6834 and re-add by calling out to command-line for example

Review Instructions
Builds should pass

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6239

Security and Privacy

No real change aside from transitive improvements

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Feb 9, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.53%. Comparing base (6932dc3) to head (4b0d149).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5804      +/-   ##
=============================================
- Coverage      74.53%   74.53%   -0.01%     
+ Complexity      5535     5533       -2     
=============================================
  Files            381      380       -1     
  Lines          19922    19918       -4     
  Branches        2057     2057              
=============================================
- Hits           14849    14845       -4     
  Misses          4085     4085              
  Partials         988      988              
Flag Coverage Δ
bitbuckettests 26.49% <ø> (-0.01%) ⬇️
hoverflytests 27.95% <ø> (-0.02%) ⬇️
integrationtests 56.60% <ø> (-0.01%) ⬇️
languageparsingtests 10.97% <ø> (-0.02%) ⬇️
localstacktests 21.40% <ø> (+<0.01%) ⬆️
toolintegrationtests 30.25% <ø> (+<0.01%) ⬆️
unit-tests_and_non-confidential-tests 25.91% <ø> (-0.02%) ⬇️
workflowintegrationtests 38.08% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-yuen
Copy link
Member Author

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@denis-yuen
Copy link
Member Author

Note to self: updated to 4.0.7, but need to test without forced jersey override

@denis-yuen
Copy link
Member Author

Note to self: updated to 4.0.7, but need to test without forced jersey override

4.0.10 avoids this

@denis-yuen denis-yuen changed the title update the dropwizard things update the dropwizard things to 4.0.10 Nov 5, 2024
@denis-yuen
Copy link
Member Author

Issue looks a lot like docker-java/docker-java#2363
Wait for release and update to https://github.com/docker-java/docker-java/releases

@denis-yuen denis-yuen mentioned this pull request Nov 14, 2024
9 tasks
@denis-yuen denis-yuen changed the title update the dropwizard things to 4.0.10 update dropwizard things to 4.0.11 Dec 5, 2024
@denis-yuen denis-yuen changed the title update dropwizard things to 4.0.11 update dropwizard to 4.0.11 Dec 5, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

@denis-yuen denis-yuen marked this pull request as ready for review December 5, 2024 16:49
@denis-yuen denis-yuen requested review from a team, coverbeck, david4096, hyunnaye, kathy-t and svonworl and removed request for a team December 5, 2024 16:50
@denis-yuen denis-yuen merged commit 5dfa2f7 into develop Dec 5, 2024
20 checks passed
@denis-yuen denis-yuen deleted the feature/dropwizard_update_4_0_6 branch December 5, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants