Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@hyunnaye
Copy link
Contributor

@hyunnaye hyunnaye commented Dec 12, 2024

Description
This PR adds the "include" parameter in getWorkflowVersions and getPublicWorkflowVersions endpoints. This allows the UI to get data like metrics for each version.

Review Instructions
Test getting metrics for a workflow version using the include queryparam.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6341

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@hyunnaye hyunnaye self-assigned this Dec 12, 2024
@hyunnaye hyunnaye requested a review from kathy-t December 12, 2024 22:43
@codecov
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.83%. Comparing base (098dfa5) to head (39fb94c).

❗ There is a different number of reports uploaded between BASE (098dfa5) and HEAD (39fb94c). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (098dfa5) HEAD (39fb94c)
toolintegrationtests 2 1
unit-tests_and_non-confidential-tests 4 0
workflowintegrationtests 3 2
languageparsingtests 1 0
hoverflytests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6055      +/-   ##
=============================================
- Coverage      74.41%   65.83%   -8.58%     
+ Complexity      5629     4980     -649     
=============================================
  Files            386      386              
  Lines          20191    20193       +2     
  Branches        2085     2085              
=============================================
- Hits           15025    13295    -1730     
- Misses          4167     5917    +1750     
+ Partials         999      981      -18     
Flag Coverage Δ
bitbuckettests 26.15% <0.00%> (-0.01%) ⬇️
hoverflytests ?
integrationtests 55.94% <50.00%> (-0.01%) ⬇️
languageparsingtests ?
localstacktests 21.12% <0.00%> (-0.01%) ⬇️
toolintegrationtests 29.32% <100.00%> (-0.58%) ⬇️
unit-tests_and_non-confidential-tests ?
workflowintegrationtests 36.74% <50.00%> (-0.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

@hyunnaye hyunnaye requested a review from denis-yuen January 6, 2025 20:19
@hyunnaye hyunnaye merged commit 2552462 into develop Jan 6, 2025
21 of 22 checks passed
@hyunnaye hyunnaye deleted the feature/seab-6341 branch January 6, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants