-
Notifications
You must be signed in to change notification settings - Fork 29
SEAB-6341: add include query param to version endpoints #6055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dockstore-webservice/src/main/java/io/dockstore/webservice/resources/WorkflowResource.java
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6055 +/- ##
=============================================
- Coverage 74.41% 65.83% -8.58%
+ Complexity 5629 4980 -649
=============================================
Files 386 386
Lines 20191 20193 +2
Branches 2085 2085
=============================================
- Hits 15025 13295 -1730
- Misses 4167 5917 +1750
+ Partials 999 981 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dockstore-webservice/src/main/java/io/dockstore/webservice/resources/WorkflowResource.java
Show resolved
Hide resolved
|
Description
This PR adds the "include" parameter in
getWorkflowVersionsandgetPublicWorkflowVersionsendpoints. This allows the UI to get data like metrics for each version.Review Instructions
Test getting metrics for a workflow version using the include queryparam.
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6341
Security and Privacy
If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.
e.g. Does this change...
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install@RolesAllowedannotation