Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@svonworl
Copy link
Contributor

@svonworl svonworl commented Dec 10, 2024

Description
Recently, a Quay image sha changed, breaking an integration test. We adjusted the tag/branch in dockstore-testing/hello-wdl-workflow for the new sha. This PR adjusts the referencing test similarly. For more information, see this Slack thread: https://ucsc-gi.slack.com/archives/C05EZH3RVNY/p1733851040745499

Review Instructions
Confirm integration tests pass.

Issue
None.

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.56%. Comparing base (4786a28) to head (7337f1b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6052      +/-   ##
=============================================
+ Coverage      73.67%   74.56%   +0.89%     
- Complexity      5482     5536      +54     
=============================================
  Files            380      380              
  Lines          19921    19921              
  Branches        2056     2056              
=============================================
+ Hits           14676    14854     +178     
+ Misses          4257     4080     -177     
+ Partials         988      987       -1     
Flag Coverage Δ
bitbuckettests 26.50% <ø> (ø)
hoverflytests 27.97% <ø> (ø)
integrationtests 56.60% <ø> (ø)
languageparsingtests 10.97% <ø> (ø)
localstacktests 21.40% <ø> (ø)
toolintegrationtests 30.28% <ø> (ø)
unit-tests_and_non-confidential-tests 25.91% <ø> (ø)
workflowintegrationtests 38.07% <ø> (+4.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svonworl svonworl merged commit 2e5d606 into develop Dec 11, 2024
24 checks passed
@svonworl svonworl deleted the feature/adjust-image-sha-in-test branch December 11, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants