Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Jan 7, 2025

Description
See linked PR, this is the hotfix counterpart

Review Instructions
qa should be functional, postgres 16.1 to 16.4 upgrade only contains fixes and no new features

Issue
See also #6063

Security and Privacy

None, this is a straight upgrade

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Jan 7, 2025
@denis-yuen
Copy link
Member Author

Codacy alert seems like an error on their end, clicking through it's ok as expected since there are no real code changes

@denis-yuen denis-yuen changed the title try 16.4 postgres 16.4 update Jan 7, 2025
@denis-yuen denis-yuen marked this pull request as ready for review January 7, 2025 21:31
@denis-yuen denis-yuen requested review from a team, hyunnaye, kathy-t and svonworl and removed request for a team January 7, 2025 21:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

@codecov
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.52%. Comparing base (92b8150) to head (b82ca12).

Additional details and impacted files
@@                 Coverage Diff                 @@
##             hotfix/1.16.4    #6064      +/-   ##
===================================================
+ Coverage            72.22%   74.52%   +2.29%     
- Complexity            5280     5507     +227     
===================================================
  Files                  381      381              
  Lines                19800    19800              
  Branches              2044     2044              
===================================================
+ Hits                 14300    14755     +455     
+ Misses                4531     4065     -466     
- Partials               969      980      +11     
Flag Coverage Δ
bitbuckettests 26.64% <ø> (ø)
hoverflytests 27.91% <ø> (ø)
integrationtests 56.78% <ø> (ø)
languageparsingtests 11.04% <ø> (?)
localstacktests 21.55% <ø> (?)
toolintegrationtests 30.01% <ø> (ø)
unit-tests_and_non-confidential-tests 25.84% <ø> (ø)
workflowintegrationtests 38.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-yuen denis-yuen merged commit ca55d02 into hotfix/1.16.4 Jan 9, 2025
19 of 20 checks passed
@denis-yuen denis-yuen deleted the postgres_update_164 branch January 9, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants