Fix http imports from a local secondary file #6065
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were creating a ResolvedImportBundle that didn't include existing resolvers.
The second parameter name in
ResolvedImportBundleisnewResolvers, which I had previously interpreted to mean any resolvers not already in the list of the resolvers. But Scala Lists are by default immutable, so I came to realize thatthey wanted a new complete list of resolvers.
The
:+operand creates a new list from an existing list and an item.Having all resolvers present makes it work; I don't exactly understand how Cromwell knows which of the resolvers to use, but it makes sense given the list is being passed around.
Tested manually using instructions in the GitHub issue.
There should ideally still be a test for this.Denis added a test.Review Instructions
Follow the instructions in #6061.
Issue
#6061
DOCK-2609
Security and Privacy
None
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install@RolesAllowedannotation