Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Jan 13, 2025

Description
swagger validation broke due to automatic github upgrade to ubuntu 24.04
actions/runner-images#10636

Turns out github action has switched their repo and newer versions just work, so switched and pinned ubuntu version

Review Instructions
swagger/openapi validation job should just work in develop

Issue
n/a

Security and Privacy

None

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Jan 13, 2025
@denis-yuen denis-yuen marked this pull request as ready for review January 13, 2025 20:06
@denis-yuen denis-yuen requested review from a team, hyunnaye, kathy-t and svonworl and removed request for a team January 13, 2025 20:07
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.43%. Comparing base (d082c91) to head (b731edc).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #6069   +/-   ##
==========================================
  Coverage      74.43%   74.43%           
  Complexity      5636     5636           
==========================================
  Files            386      386           
  Lines          20196    20196           
  Branches        2086     2086           
==========================================
  Hits           15033    15033           
  Misses          4166     4166           
  Partials         997      997           
Flag Coverage Δ
bitbuckettests 26.15% <ø> (+<0.01%) ⬆️
hoverflytests 27.57% <ø> (ø)
integrationtests 55.96% <ø> (ø)
languageparsingtests 10.83% <ø> (ø)
localstacktests 21.26% <ø> (ø)
toolintegrationtests 29.90% <ø> (ø)
unit-tests_and_non-confidential-tests 26.39% <ø> (ø)
workflowintegrationtests 37.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-yuen denis-yuen merged commit fc4d73b into develop Jan 16, 2025
20 checks passed
@denis-yuen denis-yuen deleted the feature/fix_swagger_validation branch January 16, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants