Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@hyunnaye
Copy link
Contributor

@hyunnaye hyunnaye commented Feb 10, 2025

Description
Cherry pick to the hotfix branch

Review Instructions
N/A

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6917

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

* add Toil to enum

* test

* try to see if this fix build

* try to see if this fix build

* try to see if this fix build

* try to see if this fix build

* try to see if this fix build

* try to see if this fix build
@hyunnaye hyunnaye self-assigned this Feb 10, 2025
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.50%. Comparing base (ad2a6a8) to head (ed64593).
Report is 2 commits behind head on hotfix/1.16.6.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             hotfix/1.16.6    #6077       +/-   ##
====================================================
+ Coverage            45.16%   74.50%   +29.33%     
- Complexity            3414     5506     +2092     
====================================================
  Files                  381      381               
  Lines                19800    19801        +1     
  Branches              2044     2044               
====================================================
+ Hits                  8943    14752     +5809     
+ Misses               10017     4069     -5948     
- Partials               840      980      +140     
Flag Coverage Δ
bitbuckettests 26.64% <100.00%> (?)
hoverflytests 27.91% <100.00%> (?)
integrationtests 56.76% <100.00%> (?)
languageparsingtests 11.04% <100.00%> (+<0.01%) ⬆️
localstacktests 21.55% <100.00%> (+<0.01%) ⬆️
toolintegrationtests 30.01% <100.00%> (+<0.01%) ⬆️
unit-tests_and_non-confidential-tests 25.85% <100.00%> (+<0.01%) ⬆️
workflowintegrationtests 38.05% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyunnaye hyunnaye requested review from kathy-t and svonworl February 10, 2025 16:29
@hyunnaye hyunnaye merged commit 5bde580 into hotfix/1.16.6 Feb 11, 2025
18 of 20 checks passed
@hyunnaye hyunnaye deleted the SEAB-6971-hotfix branch February 11, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants