SEAB-7080: Use tag creation date as DOI publication date #6096
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the webservice to use
WorkflowVersion.lastModified, which for most workflows is the time at which the corresponding tag was created on GitHub, to generate the version DOI publication date.In general, this change will make the version DOIs appear in a sane order, but may cause ordering problems when subsequent retroactive automatic DOIs are added to workflows that had pre-existing non-automatic DOIs, or pre-existing automatic DOIs that were generated for tags found when our GitHub app was installed. Fortunately, this is a small number of workflows.
Somewhat suboptimally, Zenodo accepts a date, but not a date+time, in the publication date field for a submission (https://help.zenodo.org/docs/deposit/describe-records/publication-date/). So, if there's lots of tags created the same day, they may still appear "out of order". This includes the DOIs that are produced for
DockstoreTestUser4's workflow [when the smoke tests are run?].Review Instructions
Generate a sandbox DOI for a tag and confirm that the publication date is the tag's GitHub creation date, rather than the current time. This may be tricky. Alternatively, check the sandbox Zenodo Dockstore community for version DOIs wherein the upload and publication dates do not match, and confirm that the publication date matches the tag creation date.
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-7080
Security and Privacy
If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.
e.g. Does this change...
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install@RolesAllowedannotation