Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@svonworl
Copy link
Contributor

@svonworl svonworl commented Apr 30, 2025

Description
Cherry pick #6100 to release/1.17.0 branch.

Review Instructions
see #6100

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6958

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@svonworl svonworl self-assigned this Apr 30, 2025
@svonworl svonworl requested review from denis-yuen and kathy-t April 30, 2025 16:56
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.19%. Comparing base (44f417b) to head (29581e3).
Report is 1 commits behind head on release/1.17.0.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/1.17.0    #6105      +/-   ##
====================================================
- Coverage             74.23%   74.19%   -0.04%     
+ Complexity             5660     5657       -3     
====================================================
  Files                   389      389              
  Lines                 20324    20324              
  Branches               2098     2098              
====================================================
- Hits                  15087    15079       -8     
- Misses                 4236     4244       +8     
  Partials               1001     1001              
Flag Coverage Δ
bitbuckettests 25.94% <0.00%> (ø)
hoverflytests 27.64% <0.00%> (ø)
integrationtests 56.08% <0.00%> (ø)
languageparsingtests 10.82% <0.00%> (ø)
localstacktests 21.34% <0.00%> (ø)
regressionintegrationtests ?
toolintegrationtests 29.92% <0.00%> (ø)
unit-tests_and_non-confidential-tests 26.30% <100.00%> (ø)
workflowintegrationtests 37.38% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svonworl svonworl merged commit ff94479 into release/1.17.0 Apr 30, 2025
23 of 24 checks passed
@svonworl svonworl deleted the cherrypick-notebook-commit-to-release branch April 30, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants