Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update aws in order to update netty #6118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
denis-yuen merged 5 commits into from
Jun 6, 2025
Merged

update aws in order to update netty #6118

denis-yuen merged 5 commits into from
Jun 6, 2025

Conversation

@denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Jun 4, 2025 •
edited
Loading

Description
update aws in order to get at problematic netty
GHSA-4g8c-wm8x-jfhw
GHSA-xq3w-v528-46rv
GHSA-389x-839f-4rhx

localstack story appears to be that a newer aws library was incompatible with localstack. Updating localstack broke since it appears that a temporary S3 provider that we were using no longer works, removing it seems to have fixed the issue. Note running these localstack tests takes a lot longer locally for some reason even via Maven. Runtimes on circle ci seem fine

Review Instructions
just check third party versions file

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-7178

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Jun 4, 2025
@denis-yuen
Copy link
Member Author

denis-yuen commented Jun 5, 2025 •
edited
Loading

note to self: failure in localstack-tests looks like a legit aws issue
localstack/localstack#6659

@denis-yuen
Copy link
Member Author

denis-yuen commented Jun 5, 2025 •
edited
Loading

note for tomorrow: 3.8.1 works locally, 4.5.0 does not
Can confirm ExtendedMetricsTRSOpenApiIT runs fine locally via IDE which is odd

Interesting, it fails when running via Maven but not via IDE ./mvnw clean install -Plocalstack-tests

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Jun 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.18%. Comparing base (21521eb) to head (11d867e).
Report is 3 commits behind head on develop.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #6118   +/-   ##
==========================================
  Coverage      74.18%   74.18%           
  Complexity      5660     5660           
==========================================
  Files            389      389           
  Lines          20331    20331           
  Branches        2100     2100           
==========================================
  Hits           15082    15082           
  Misses          4247     4247           
  Partials        1002     1002
Flag Coverage Δ
bitbuckettests 25.94% <ø> (ø)
hoverflytests 27.62% <ø> (ø)
integrationtests 56.08% <ø> (ø)
languageparsingtests 10.82% <ø> (ø)
localstacktests 21.34% <ø> (ø)
toolintegrationtests 29.90% <ø> (ø)
unit-tests_and_non-confidential-tests 26.31% <ø> (ø)
workflowintegrationtests 37.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@denis-yuen denis-yuen marked this pull request as ready for review June 6, 2025 17:12
@denis-yuen denis-yuen requested review from a team, kathy-t and svonworl and removed request for a team June 6, 2025 17:13
@denis-yuen denis-yuen merged commit 8ab7926 into develop Jun 6, 2025
24 checks passed
@denis-yuen denis-yuen deleted the feature/aws_update branch June 6, 2025 21:06
@svonworl svonworl mentioned this pull request Aug 21, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svonworl svonworl svonworl approved these changes

+1 more reviewer

@kathy-t kathy-t kathy-t approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@denis-yuen denis-yuen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@denis-yuen @kathy-t @svonworl