SEAB-7194: Add max weekly execution count endpoint #6156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-yuen
approved these changes
Sep 4, 2025
| for (int i = 0, n = values.size(); i < n; i++) { | ||
| Instant binStart = oldestBinStart.plusSeconds(i * secondsPerWeek); | ||
| Instant binEnd = binStart.plusSeconds(secondsPerWeek); | ||
| if (binEnd.compareTo(onOrAfter) >= 0) { |
Member
There was a problem hiding this comment.
Seems like this could be calculated in the JPA with a "max", but this is maybe known given
This endpoint may be ephemeral, it might be supplanted when we implement workflow-level metrics support.
| @NamedQuery(name = "io.dockstore.webservice.core.Workflow.getWorkflowIdsEligibleForRetroactiveDoi", query = "SELECT DISTINCT w.id FROM Workflow w JOIN w.workflowVersions v LEFT JOIN v.versionMetadata vm LEFT JOIN vm.dois d WHERE w.isPublished AND w.autoGenerateDois AND NOT w.archived AND v.referenceType = 'TAG' AND v.valid AND NOT vm.hidden AND d IS NULL"), | ||
| @NamedQuery(name = "io.dockstore.webservice.core.Workflow.getWorkflowIdsWithGitHubOrManualDoi", query = "SELECT DISTINCT w.id FROM Workflow w JOIN w.workflowVersions v JOIN v.versionMetadata vm JOIN vm.dois d WHERE d.initiator IN ('GITHUB', 'USER')") | ||
| @NamedQuery(name = "io.dockstore.webservice.core.Workflow.getWorkflowIdsWithGitHubOrManualDoi", query = "SELECT DISTINCT w.id FROM Workflow w JOIN w.workflowVersions v JOIN v.versionMetadata vm JOIN vm.dois d WHERE d.initiator IN ('GITHUB', 'USER')"), | ||
| @NamedQuery(name = "io.dockstore.webservice.core.Workflow.getWeeklyExecutionCountsForAllVersions", query = "SELECT VALUE(c).weeklyExecutionCounts FROM Workflow w JOIN w.workflowVersions v JOIN v.metricsByPlatform mbp ON KEY(mbp) = 'ALL' JOIN VALUE(mbp).executionStatusCount esc JOIN esc.count c ON KEY(c) = 'ALL' WHERE w.id = :id AND VALUE(c).weeklyExecutionCounts IS NOT NULL"), |
Member
There was a problem hiding this comment.
Could narrow things down by feeding the time into the query and not returning counts for versions that were not updated anywhere near onOrAfterEpochSecond
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6156 +/- ##
=============================================
+ Coverage 72.32% 74.03% +1.70%
- Complexity 5537 5712 +175
=============================================
Files 397 397
Lines 20522 20540 +18
Branches 2108 2111 +3
=============================================
+ Hits 14842 15206 +364
+ Misses 4683 4331 -352
- Partials 997 1003 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an endpoint that calculates the maximum weekly execution count for all versions of a workflow, for all weeks on/after a specified date.
The UI will use this endpoint to calculate the maximum Y axis value for the "small multiples" weekly execution count graphs that are being added to the versions table.
Alternatively, we could calculate the maximum client-side, by simply downloading all the versions with their metrics. However, that would be a potentially huge amount of information (some of the broad repos have more than 1000 versions) and could take seconds.
This endpoint may be ephemeral, it might be supplanted when we implement workflow-level metrics support.
The code that calculates the maximum is written with robustness in mind. It could be more efficient, but in this case, it's ok if we burn a few extra cycles.
Review Instructions
Try a few queries (like the following) and confirm that the response is rational:
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-7194
Security and Privacy
If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.
e.g. Does this change...
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install@RolesAllowedannotation