-
Notifications
You must be signed in to change notification settings - Fork 29
SEAB-6531: Fix some .dockstore.yml inference bugs, reset version #6162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6162 +/- ##
=============================================
- Coverage 74.03% 74.02% -0.01%
- Complexity 5710 5712 +2
=============================================
Files 397 397
Lines 20540 20543 +3
Branches 2111 2112 +1
=============================================
+ Hits 15206 15207 +1
- Misses 4331 4332 +1
- Partials 1003 1004 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
| } | ||
|
|
||
| private Optional<Path> toAbsolutePath(Path currentPath, String relativeOrAbsolutePath) { | ||
| Path parentPath = currentPath.getParent(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little puzzled, this seems to never resolve to the previous code no matter what condition. Was this completely broken and just unnoticed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's the same if the currentPath is the root?
In other circumstances, could use some unit tests
Description
This PR fixes a couple of bugs in the
.dockstore.ymlinference code:wdl) to be considered as the primary descriptor of an entry, creating potentially many spurious entries for helper files in the resulting.dockstore.yml. The root cause was an errant path manipulation that was probably introduced during thePathconversion. Fixed.It also resets to the
SNAPSHOTversion.Originally, this PR included a tweak that constructed a GitHub ref where a branch name was being used, avoiding some default output and maybe some extra requests. However, the unfixed code seems to [eventually?] do the right thing, and to avoid unintended consequences this late in the deploy cycle, I removed the change.
Review Instructions
Infer a
.dockstore.ymlfor github.com/PacificBiosciences/HiFi-human-WGS-WDL and confirm that the inferred.dockstore.ymlcontains two entries.Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6531
Security and Privacy
If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.
e.g. Does this change...
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install@RolesAllowedannotation