Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Oct 11, 2025

Description
2.1.5 ran into a bad merge
2.1.6 ran into a build issue (shade had been modified to make the draft deletion script executable, but conflicted with our dockstore build)

This tests 2.1.7 zenodo client now with InvenioRDM endpoints that should really be namespaced into a separate tag/namespace

Review Instructions
Build, use, deploy to QA.
Try out zenodo operations

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-7226

Security and Privacy

None

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Oct 11, 2025
@denis-yuen denis-yuen changed the title test this update test zenodo clien update Oct 11, 2025
@denis-yuen denis-yuen changed the title test zenodo clien update test zenodo client update Oct 11, 2025
@codecov
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.07%. Comparing base (09ed8d4) to head (9f2ca3c).
⚠️ Report is 1 commits behind head on hotfix/1.18.1.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             hotfix/1.18.1    #6177      +/-   ##
===================================================
+ Coverage            72.87%   74.07%   +1.19%     
- Complexity            5618     5724     +106     
===================================================
  Files                  397      397              
  Lines                20571    20571              
  Branches              2116     2116              
===================================================
+ Hits                 14992    15238     +246     
+ Misses                4529     4326     -203     
+ Partials              1050     1007      -43     
Flag Coverage Δ
bitbuckettests 25.83% <0.00%> (ø)
hoverflytests 27.43% <100.00%> (ø)
integrationtests 56.02% <0.00%> (ø)
languageparsingtests 10.79% <0.00%> (ø)
localstacktests 21.19% <0.00%> (ø)
toolintegrationtests 29.76% <0.00%> (ø)
unit-tests_and_non-confidential-tests 26.10% <0.00%> (+11.69%) ⬆️
workflowintegrationtests 39.51% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

@denis-yuen denis-yuen requested review from a team and svonworl and removed request for a team October 11, 2025 07:36
@denis-yuen denis-yuen marked this pull request as ready for review October 14, 2025 14:33
@denis-yuen denis-yuen merged commit 4aa71d6 into hotfix/1.18.1 Oct 14, 2025
22 of 24 checks passed
@denis-yuen denis-yuen deleted the update_zenodo_client branch October 14, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants