Backport #6167 from 2.6 to 2.5.x branch #6852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigi
commented
Nov 27, 2017
- Test mocks cherry-picked from 2.6 branch
- Code cleanup for php5.4 support
(cherry picked from commit 60b6073)
…nceGenerator (cherry picked from commit edffb4d)
…equence nextval (cherry picked from commit 71b040c)
(cherry picked from commit 571115c)
… is used instead of `fetchColumn` (cherry picked from commit d2be4a2)
…cblocks/return-types (cherry picked from commit 462481e)
…r readability and error messages (cherry picked from commit a97c265)
|
Linking #6167 |
|
@gigi thanks for your help! I'll do the last checks and get it merged (and maybe released) later today 👍 |
|
@gigi 🚢 thanks! |
|
Thank you guys! You're doing a great job! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.