Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Split and deprecate AbstractQuery#useResultCache() #7701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2019
Merged

Split and deprecate AbstractQuery#useResultCache() #7701

merged 2 commits into from
Nov 16, 2019

Conversation

@someniatko
Copy link
Contributor

@someniatko someniatko commented May 7, 2019

Split useResultCache($boolFlag, ...) into enableResultCache() and disableResutCache().

To create tests for enableResultCache() and disableResultCache(), useResultCache()'s tests were copy-pasted, but I think that's fine.

This is proper PR, original one is #7213

@someniatko someniatko changed the base branch from master to 2.7 May 7, 2019 20:27
@someniatko someniatko mentioned this pull request May 7, 2019
Closed
@greg0ire
Copy link
Member

greg0ire commented May 7, 2019

IMO you should fixup the first commit into the new one. Do you know how to do this without creating a new PR? Otherwise I can help.

@someniatko
Copy link
Contributor Author

someniatko commented May 8, 2019

@greg0ire yes. Last time i recreated the PR because a) initial branch was wrong (i committed directly to 2.7 of my fork), and b) interactive rebase rendered in merge conflicts for some reason, even if i tried to rebase without changing anything in commits order. It was easier to just start over and cherry-pick.

Okay, will rebase and force push now.

@someniatko someniatko force-pushed the deprecate-use-result-cache branch from 5e891fc to 0abffd1 Compare May 8, 2019 07:26
@someniatko
Copy link
Contributor Author

someniatko commented May 23, 2019

@greg0ire ping. I noticed you've put "Deprecation" label and "2.7.0" milestone to the previous PR, #7213. I think you should at least do the same for this one.

greg0ire
greg0ire reviewed May 23, 2019
View reviewed changes
@someniatko someniatko force-pushed the deprecate-use-result-cache branch from df22e8a to 67a62ae Compare May 25, 2019 17:18
greg0ire
greg0ire previously approved these changes May 25, 2019
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It reads far better now, great work!

@Ocramius Ocramius added this to the 2.7.0 milestone May 27, 2019
@greg0ire greg0ire requested a review from a team June 22, 2019 13:57
@greg0ire
Copy link
Member

greg0ire commented Jun 22, 2019

Are there no docs that need to be updated?

@jwage
Copy link
Member

jwage commented Jun 22, 2019

The deprecation should be added to the UPGRADE.md document too?

SenseException
SenseException requested changes Jun 24, 2019
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useResultCache appears in https://www.doctrine-project.org/projects/doctrine-orm/en/2.6/reference/caching.html#result-cache and needs to be mentioned/adapted for 2.7.

@someniatko
Copy link
Contributor Author

someniatko commented Jun 27, 2019

Got it, will add the requested changes to documentation and UPGRADE.md

@someniatko
Copy link
Contributor Author

someniatko commented Jul 3, 2019

Made the requested changes to documentation. Also i'd like to reject @SenseException 's suggestion for the reasons described above.

@greg0ire greg0ire requested a review from SenseException July 3, 2019 18:56
SenseException
SenseException previously approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Will those changes be merged or picked into master or is another PR for master needed?

@someniatko
Copy link
Contributor Author

someniatko commented Jul 23, 2019

@SenseException there is a pull request to master: #7214
It will need some work as well, like updating documentation. However I'd wait for this pull request to be merged before working on master's one.

@greg0ire greg0ire force-pushed the deprecate-use-result-cache branch from 9c88aa8 to fe7c61e Compare November 14, 2019 21:10
@lcobucci lcobucci force-pushed the deprecate-use-result-cache branch from fe7c61e to e8f265d Compare November 16, 2019 01:00
lcobucci
lcobucci approved these changes Nov 16, 2019
View reviewed changes
Copy link
Member

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@someniatko thanks!

@lcobucci lcobucci merged commit 977985f into doctrine:2.7 Nov 16, 2019
@greg0ire greg0ire mentioned this pull request Nov 29, 2019
Closed
vilartoni added a commit to Emagister/doctrine-orm that referenced this pull request Jan 14, 2020
@vilartoni
Merge tag 'v2.7.0' of git://github.com/doctrine/orm into doctrine-ori…
7a3ae57 
…gin-master

v2.7.0

[![Build Status](https://travis-ci.org/doctrine/orm.svg?branch=v2.7.0)](https://travis-ci.org/doctrine/orm)

This release solves Symfony 5.0 compatibility issues, some small improvements, and adds
various deprecation notices.

Please read carefully the [upgrade to 2.7
notes](https://github.com/doctrine/orm/blob/2.7/UPGRADE.md#upgrade-to-27) to know more
about the reasons and how to fix the deprecation messages.

---

- Total issues resolved: **1**
- Total pull requests resolved: **15**
- Total contributors: **10**

Deprecation
-----------

 - [7911: Be explicit about which Doctrine package in message](doctrine#7911) thanks to @lcobucci
 - [7909: Add deprecation messages](doctrine#7909) thanks to @lcobucci
 - [7901: Add deprecation warnings for 2.7.x](doctrine#7901) thanks to @lcobucci
 - [7701: Split and deprecate AbstractQuery#useResultCache()](doctrine#7701) thanks to @someniatko

CI
--

 - [7904: Make sure composer files are valid](doctrine#7904) thanks to @greg0ire
 - [7600: &doctrine#91;2.7&doctrine#93; CI: Test against PHP 7.4snapshot instead of nightly (8.0)](doctrine#7600) thanks to @Majkl578

Improvement
-----------

 - [7876: Fix compat of commands with Symfony 5](doctrine#7876) thanks to @nicolas-grekas
 - [7829: Skip Paginator LIMIT subquery and WHERE IN if query do not have LIMIT](doctrine#7829) thanks to @Seb33300
 - [7723: Allow Symfony 5.0](doctrine#7723) thanks to @nicolas-grekas
 - [7710: Prettified arrays in tool command orm:mapping:describe](doctrine#7710) thanks to @rtek
 - [7340: Fix config template for PHPUnit >= 7.2](doctrine#7340) thanks to @guilliamxavier

BC Break,Improvement
--------------------

 - [7863: Paginator: Skip limit subquery if not required](doctrine#7863) thanks to @Seb33300

Documentation
-------------

 - [7382: Update homepage](doctrine#7382) thanks to @Majkl578

Bug
---

 - [7326: Cherry-pick doctrine#7307 to fix remaining usages of deprecated ClassLoader and Inflector from doctrine/common](doctrine#7326) thanks to @nicolas-grekas
 - [7079: Fix getJoinTableName for sqlite with schema attribute](doctrine#7079) thanks to @mairo744

BC Break,Deprecation,Improvement
--------------------------------

 - [6803: Deprecation of EntityManager copy method](doctrine#6803) thanks to @SenseException
@derrabus derrabus mentioned this pull request May 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greg0ire greg0ire greg0ire left review comments

@SenseException SenseException SenseException left review comments

+1 more reviewer

@lcobucci lcobucci lcobucci approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@greg0ire greg0ire

Labels

Deprecation

Projects

None yet

Milestone

2.7.0

Development

Successfully merging this pull request may close these issues.

6 participants

@someniatko @greg0ire @jwage @lcobucci @SenseException @Ocramius