Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Mention SQL logger impact on batch processing #7849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2019
Merged

Mention SQL logger impact on batch processing #7849

merged 2 commits into from
Oct 2, 2019

Conversation

@axi
Copy link
Contributor

@axi axi commented Oct 1, 2019

Looking for a way to improve one of our bulk update treatment, I went back to this page then found elsewhere that setting logger to null was a really effective way to improve time and memory consumption. Might be a right place to state it ? Don't know if my edit style is ok

@axi
Update batch-processing.rst
7c8c090 
Looking for a way to improve one of our bulk update treatment, I went back to this page then found elsewhere that setting logger to null was a really effective way to improve time and memory consumption. Might be a right place to state it ? Don't know if my edit style is ok
lcobucci
lcobucci suggested changes Oct 1, 2019
View reviewed changes
Copy link
Member

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axi thanks for your contribution, what do you think about this?

@lcobucci lcobucci added this to the 2.6.5 milestone Oct 1, 2019
@lcobucci lcobucci changed the title Update batch-processing.rst Mention SQL logger impact on batch processing Oct 1, 2019
lcobucci
lcobucci approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axi thanks for your contribution 👍

@lcobucci lcobucci merged commit b226043 into doctrine:2.6 Oct 2, 2019
@lcobucci lcobucci assigned lcobucci and unassigned axi Oct 2, 2019
@axi
Copy link
Contributor Author

axi commented Oct 2, 2019

I knew I would do something for doctrine someday ;-) Keep going !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lcobucci lcobucci lcobucci approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lcobucci lcobucci

Labels

Documentation

Projects

None yet

Milestone

2.6.5

Development

Successfully merging this pull request may close these issues.

2 participants

@axi @lcobucci