-
-
Notifications
You must be signed in to change notification settings - Fork 213
Cleanup: drop unsupported php versions #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
-1 on dropping PHP 5.5. Major OS distros support LTS and we should be inline with their versions too |
.travis.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does more than your ticket claims to do (you actually dropped PHP 5.5 support
|
Will restore 5.5 for 1.6: absolutely gonna kill it in further minor versions though. |
|
@guilhermeblanco restored |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line if [[ $TRAVIS_PHP_VERSION =~ 5.[34] ]] can be removed as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
@Ocramius Symfony 3 minimum version is 5.5.9, and it depends on doctrine/cache. So you will either have to keep support for PHP 5.5 in following doctrine/cache versions, or provide LTS support for 1.6 for the next few years (so that Symfony can ship with a maintained version of doctrine/cache). |
|
And you should check what broke the mongo tests |
|
I personally don't care but even if the EOL of PHP 5.4 has been reached, it is still supported in Debian Wheezy until may 2018: https://packages.debian.org/Wheezy/php5 |
|
We're not a support shop, folks! We do security support and we support what Staying in sync with the PHP releases (official ones) reduces our surface
|
|
You should totally drop support for all PHP 5.x versions. |
|
-1 on removing 5.5. It's not EOLed yet. Try again in 6 months |
|
I love this drop of 5.5 \o/ |
|
To those still commenting about 5.5, it was reverted at 9ecf923 last week. |
…iving from now on.
9ecf923 to
24e3969
Compare
…eration (for now)
…rsions Cleanup: drop unsupported php versions
|
PHP 5.5 goes EOL in about 6 months. Maybe just wait till then? |
|
Personally, I'm not massively bothered, as long as php 5.6 support remains for at least 1 more year. |
|
@GrahamCampbell 5.5 is still supported in this PR |
|
Yeh, I know. ;) I was just referring to your comment when you said you'd like to drop it in the very near future, |
|
I'm very glad php 5.3 support is finally dropped. ;) |
|
@GrahamCampbell we will likely move to 7.0 for 1.7.x, since 5.6 is not used in any linux LTS (as far as I know) |
|
That's a very big jump. ;( |
|
@GrahamCampbell not a very big one, to be honest. See #109 (comment) again |
|
@Ocramius Just for info Debian Jessie (LTS - end of life in 2020) is shipped with PHP 5.6: https://packages.debian.org/jessie/php5 |
|
@dunglas ouch :-\ |
|
We'll be on php 9 by then, lol. |
Because http://php.net/supported-versions.php
Also: tempted to drop 5.5 as well.