Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Ocramius
Copy link
Member

@Ocramius Ocramius commented Dec 3, 2015

Because http://php.net/supported-versions.php

Also: tempted to drop 5.5 as well.

@Ocramius Ocramius added this to the 1.6.0 milestone Dec 3, 2015
@guilhermeblanco
Copy link
Member

-1 on dropping PHP 5.5.

Major OS distros support LTS and we should be inline with their versions too

.travis.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does more than your ticket claims to do (you actually dropped PHP 5.5 support

@Ocramius
Copy link
Member Author

Ocramius commented Dec 3, 2015

Will restore 5.5 for 1.6: absolutely gonna kill it in further minor versions though.

@Ocramius
Copy link
Member Author

Ocramius commented Dec 3, 2015

@guilhermeblanco restored

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line if [[ $TRAVIS_PHP_VERSION =~ 5.[34] ]] can be removed as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@stof
Copy link
Member

stof commented Dec 5, 2015

@Ocramius Symfony 3 minimum version is 5.5.9, and it depends on doctrine/cache. So you will either have to keep support for PHP 5.5 in following doctrine/cache versions, or provide LTS support for 1.6 for the next few years (so that Symfony can ship with a maintained version of doctrine/cache).
I'm not sure supporting PHP 5.5 actually requires much more work than supporting 5.6 (are you planning to use any 5.6+ feature in the library for something harder to do on 5.5 ?)

@stof
Copy link
Member

stof commented Dec 5, 2015

And you should check what broke the mongo tests

@Tobion Tobion mentioned this pull request Dec 5, 2015
@dunglas
Copy link
Contributor

dunglas commented Dec 5, 2015

I personally don't care but even if the EOL of PHP 5.4 has been reached, it is still supported in Debian Wheezy until may 2018: https://packages.debian.org/Wheezy/php5

@Ocramius
Copy link
Member Author

Ocramius commented Dec 5, 2015

We're not a support shop, folks! We do security support and we support what
we can, but we can't nor will commit to having LTS stuff anyway. Symfony
LTS can simply rely on 1.5, and we'll fix security or very severe issues if
they pop up.

Staying in sync with the PHP releases (official ones) reduces our surface
of engagement, which is a better commitment than just stating that we will
support more (we simply don't have the resources for that). In general,
expect less supported versions by all packages in future, while we switch
non-current versions to security-only.
On Dec 5, 2015 11:55, "Kévin Dunglas" [email protected] wrote:

I personally don't care but even if the EOL of PHP 5.4 has been reached,
it is still supported in Debian Wheezy until may 2018:
https://packages.debian.org/Wheezy/php5


Reply to this email directly or view it on GitHub
#109 (comment).

@GeeH
Copy link

GeeH commented Dec 5, 2015

You should totally drop support for all PHP 5.x versions.

@cryptiklemur
Copy link

-1 on removing 5.5. It's not EOLed yet. Try again in 6 months

@ThaDafinser
Copy link

I love this drop of 5.5 \o/

@Ocramius
Copy link
Member Author

Ocramius commented Dec 9, 2015

To those still commenting about 5.5, it was reverted at 9ecf923 last week.

@Ocramius Ocramius force-pushed the cleanup/drop-unsupported-php-versions branch from 9ecf923 to 24e3969 Compare December 9, 2015 17:17
@Ocramius Ocramius assigned Ocramius and unassigned guilhermeblanco Dec 25, 2015
Ocramius added a commit that referenced this pull request Dec 25, 2015
…rsions

Cleanup: drop unsupported php versions
@Ocramius Ocramius merged commit 9fcab91 into master Dec 25, 2015
@Ocramius Ocramius deleted the cleanup/drop-unsupported-php-versions branch December 25, 2015 10:58
@GrahamCampbell
Copy link
Contributor

PHP 5.5 goes EOL in about 6 months. Maybe just wait till then?

@GrahamCampbell
Copy link
Contributor

Personally, I'm not massively bothered, as long as php 5.6 support remains for at least 1 more year.

@Ocramius
Copy link
Member Author

@GrahamCampbell 5.5 is still supported in this PR

@GrahamCampbell
Copy link
Contributor

Yeh, I know. ;) I was just referring to your comment when you said you'd like to drop it in the very near future,

@GrahamCampbell
Copy link
Contributor

I'm very glad php 5.3 support is finally dropped. ;)

@Ocramius
Copy link
Member Author

@GrahamCampbell we will likely move to 7.0 for 1.7.x, since 5.6 is not used in any linux LTS (as far as I know)

@GrahamCampbell
Copy link
Contributor

That's a very big jump. ;(

@Ocramius
Copy link
Member Author

@GrahamCampbell not a very big one, to be honest. See #109 (comment) again

@dunglas
Copy link
Contributor

dunglas commented Dec 25, 2015

@Ocramius Just for info Debian Jessie (LTS - end of life in 2020) is shipped with PHP 5.6: https://packages.debian.org/jessie/php5

@Ocramius
Copy link
Member Author

@dunglas ouch :-\

@GrahamCampbell
Copy link
Contributor

We'll be on php 9 by then, lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants