-
-
Notifications
You must be signed in to change notification settings - Fork 213
Added MultiPutCache interface and implementations for drivers that su… #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…pports multiput Serialization and tests
|
@danut007ro seems simple/solid to me. |
|
@Ocramius Maybe the redis providers could use multi or pipeline? |
|
@Ocramius the SLC should be review to see whether it can benefit from it (this is the place benefiting from MultiGet already) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking against false seems wrong, as you will always get an array result, no?
Also, you should probably just use empty(), to avoid counting the elements when not needed.
|
I don't think it's a good idea to introduce a new interface for this. IMO MultiGetCache should be merged into Cache in 2.0 anyway. CacheProvider already emulates fetchMultiple anyway which is always possible. And the same would be true for saveMultiple. |
|
@Tobion a few things:
From my point of view, the patch is ok, but indeed we may re-design some of the interfaces for 3.x |
|
Well if ISP is really wanted for such a small domain, then it should be done fully. Currently it's just random and more based on historic reasons than on ISP. For example, why the |
|
@Tobion fully agree. I think |
|
@Ocramius I updated the code according to your review (thank you for it). Have a look and tell me what you think. Thanks! |
|
Looks good to me. Waiting for @guilhermeblanco to do a last sweep. |
|
Nice, this will become useful. |
|
got a 👍 from @guilhermeblanco! Merging \o/ Thanks @danut007ro |
Added MultiPutCache interface and implementations for drivers that su…
…pports multiput
Serialization and tests