Add reset() to PSR-6 DoctrineProvider #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return null; | ||
| } | ||
|
|
||
| public function reset() |
Contributor
Author
There was a problem hiding this comment.
We do not require an interface for this as the service_resetter of symfony doesn't require anything here: https://github.com/symfony/symfony/blob/6.1/src/Symfony/Component/HttpKernel/DependencyInjection/ServicesResetter.php
This was referenced May 10, 2022
Closed
Contributor
Author
|
The failing tests seems to be unrelated to this pull request, as they fail in MemomizeCache tests. |
Member
|
Please rebase. The CI should be green now. Also, can you please add a test that covers your change? |
afe7825 to
8d1907c
Compare
Contributor
Author
|
@derrabus Thx, rebased! |
Member
|
I'd like to merge this. Can you please add tests? |
derrabus
reviewed
May 17, 2022
Co-authored-by: Alexander M. Turek <[email protected]>
Contributor
Author
|
@derrabus Test cases added. |
derrabus
approved these changes
May 20, 2022
derrabus
added a commit
that referenced
this pull request
May 20, 2022
* 1.13.x: Add reset() to PSR-6 DoctrineProvider (#398)
Member
|
Released as 1.13.0 and 2.2.0. |
Contributor
Author
|
@derrabus Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a symfony application which run on swoole or roadrunner the services need to be resetted between the runs. Same for messenger:consume command services are resetted and require this call.
We did stumble else over problems with the caches and needed to add the
kernel.resettag to the doctrine caches: https://github.com/sulu/skeleton/pull/141/filesThe reset method was implemented here and also reseted the Namespace correctly:
https://github.com/symfony/cache/blob/4c6747cf7e56c6b8e3094dd24852bd3e364375b1/DoctrineProvider.php#L49-L55
This seems not to be added when moved the DoctrineProvider from Symfony/Cache to this repository: #366
Symfony itself added the reset in this pull request. symfony/symfony#24226. Maybe @nicolas-grekas can also gave insights about the get set Namespace here.