Deprecate AbstractAsset::getName()#7094
Merged
morozov merged 6 commits intodoctrine:4.4.xfrom Aug 17, 2025
Merged
Conversation
19200c1 to
c3f3dfd
Compare
greg0ire
reviewed
Aug 17, 2025
Member
greg0ire
left a comment
There was a problem hiding this comment.
Should docs/en/reference/schema-manager.rst change? There are many occurrences of getName() in it.
greg0ire
reviewed
Aug 17, 2025
greg0ire
previously approved these changes
Aug 17, 2025
c3f3dfd to
9af76d0
Compare
greg0ire
approved these changes
Aug 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic of
AbstractAsset::getName()is lossy. If the returned value contains a dot, it is not clear whether the dot is part of the name or a separator of the qualifier and the unqualified name.The API being developed starting with #6646 is the proper way to deal with object names.