Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DBAL-1779] Fix string column type declarations with whitespace on SQLite #2272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
billschaller merged 1 commit into from
Jan 5, 2016
Merged

[DBAL-1779] Fix string column type declarations with whitespace on SQLite #2272

billschaller merged 1 commit into from
Jan 5, 2016

Conversation

@deeky666
Copy link
Member

@deeky666 deeky666 commented Jan 5, 2016

When introspecting column types from a table in SQLite that has not been created by Doctrine and contains whitespaces in the DDL, DBAL fails to introspect the column types correctly.

Works

CREATE TABLE dbal_1779 (
    foo VARCHAR(64),
    bar TEXT(100)
)

Does not work

CREATE TABLE dbal_1779 (
    foo VARCHAR (64) ,
    bar TEXT (100)
)

fixes #1339
closes/supersedes #921

@deeky666 deeky666 added this to the 2.5.4 milestone Jan 5, 2016
@deeky666 deeky666 mentioned this pull request Jan 5, 2016
Closed
billschaller
billschaller reviewed Jan 5, 2016
View reviewed changes
tests/Doctrine/Tests/DBAL/Functional/Schema/SqliteSchemaManagerTest.php
Copy link
Member

@billschaller billschaller Jan 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs also a testListTableColumnsWithoutWhitespacesInTypeDeclarations, too.

Copy link
Member Author

@deeky666 deeky666 Jan 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeroedin-bill this is already covered by all the other DBAL tests

Copy link
Member

@billschaller billschaller Jan 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

billschaller pushed a commit that referenced this pull request Jan 5, 2016
Merge pull request #2272 from deeky666/DBAL-1779
6f0ac57 
[DBAL-1779] Fix string column type declarations with whitespace on SQLite

wheee
@billschaller billschaller merged commit 6f0ac57 into doctrine:master Jan 5, 2016
@deeky666 deeky666 deleted the DBAL-1779 branch January 5, 2016 22:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@billschaller billschaller

Labels

Bug

Projects

None yet

Milestone

2.5.4

Development

Successfully merging this pull request may close these issues.

DBAL-1779: [GH-921] Update AbstractPlatform.php

3 participants

@deeky666 @billschaller @Ocramius