This repository was archived by the owner on Aug 23, 2023. It is now read-only.
Add a little more test coverage. #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwage
commented
Jun 13, 2018
| $class = substr($class, 1); | ||
| } | ||
|
|
||
| $lastNsPos = strrpos($class, '\\'); |
Member
Author
There was a problem hiding this comment.
Found this bug when I was writing a test for the if condition above. Since we modify the $class variable with substr, the strrpos value is wrong. It isn't anything we use or rely on but figured I would fix it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.