Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Add ext-tokenizer and doctrine/annotations as dependencies #8

Merged
Ocramius merged 1 commit into from
Jun 14, 2018
Merged

Add ext-tokenizer and doctrine/annotations as dependencies #8

Ocramius merged 1 commit into from
Jun 14, 2018

Conversation

@Majkl578
Copy link
Contributor

@Majkl578 Majkl578 commented Jun 14, 2018 

$ composer-require-checker 
ComposerRequireChecker unknown-development
The following unknown symbols were found:
+-----------------------------------------+--------------------+
| unknown symbol                          | guessed dependency |
+-----------------------------------------+--------------------+
| Doctrine\Common\Proxy\Proxy             |                    |
| Doctrine\Common\Annotations\TokenParser |                    |
| T_USE                                   | ext-tokenizer      |
| T_DOC_COMMENT                           | ext-tokenizer      |
| T_CLASS                                 | ext-tokenizer      |
| T_PAAMAYIM_NEKUDOTAYIM                  | ext-tokenizer      |
| T_VAR                                   | ext-tokenizer      |
| T_PRIVATE                               | ext-tokenizer      |
| T_PROTECTED                             | ext-tokenizer      |
| T_PUBLIC                                | ext-tokenizer      |
| T_VARIABLE                              | ext-tokenizer      |
| T_FUNCTION                              | ext-tokenizer      |
| T_STRING                                | ext-tokenizer      |
| T_EXTENDS                               | ext-tokenizer      |
+-----------------------------------------+--------------------+

@Ocramius
Copy link
Member

Ocramius commented Jun 14, 2018

Woah, didn't even know that the tokens were in an extension.

@Majkl578 what about adding the require checker to the build? Does that make any sense or am I exaggerating?

@Majkl578
Copy link
Contributor Author

Majkl578 commented Jun 14, 2018

Unfortunately it returns false positives (Doctrine\Common\Proxy\Proxy here) so we can't add it to the build. :(

Ocramius
Ocramius approved these changes Jun 14, 2018
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Majkl578 makes sense, thanks

@Ocramius Ocramius self-assigned this Jun 14, 2018
@Ocramius Ocramius added the Enhancement New feature or request label Jun 14, 2018
@Ocramius Ocramius added this to the 1.0.0 milestone Jun 14, 2018
@Ocramius Ocramius merged commit d3dd796 into doctrine:master Jun 14, 2018
@Majkl578 Majkl578 deleted the missing-deps branch June 14, 2018 14:20
@jwage jwage added Improvement and removed Enhancement New feature or request labels Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Ocramius Ocramius Ocramius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Ocramius Ocramius

Labels

Improvement

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Majkl578 @Ocramius @jwage