Update doctrine/common dep to ^2.9@dev #11
Conversation
|
Nice dependency hell here. 😃 Reverse dependency doesn't allow |
|
cc @Ocramius? Tag this as 1.0.1 (then it should build on CI), then bump Common to require ^1.0.1? |
|
I think that makes sense to me.
I think that is right :) |
|
We don't really need 1.0.2 tagged or bumped again in Common, just remove Let's wait for @Ocramius. |
|
Sounds good. |
| "phpunit/phpunit": "^7.0", | ||
| "doctrine/coding-standard": "^4.0", | ||
| "doctrine/common": "^2.8", | ||
| "doctrine/common": "^2.9@dev", |
There was a problem hiding this comment.
Urgh, this is still required? (I missed that before)
There was a problem hiding this comment.
@Ocramius yes, because of this https://github.com/doctrine/reflection/blob/master/lib/Doctrine/Common/Reflection/RuntimePublicReflectionProperty.php#L25
Which is not a standalone project. We could possibly remove the tests that verify that functionality and we could temporarily remove the doctrine/common dependency for the tests. Then reintroduce the tests once doctrine/common 2.9 stable is released. It just buys is a few less steps I think.
There was a problem hiding this comment.
Also OK to have a release with a failure as long as we know what we are doing
|
@jwage 1.0.1 is not going to happen. We're at doctrine/common 2.11 in the meantime, so is this still necessary, and if so, what changes should we make before tagging 1.1.0? |
|
Fixing in #25. |
No description provided.