This repository was archived by the owner on Jan 24, 2025. It is now read-only.
fix(gatsby-theme-docz): make Props isToggle work again #1326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dangoo
approved these changes
Dec 16, 2019
There was a problem hiding this comment.
Checklist by @rakannimer:
- Add isToggle argument in Props definition : https://github.com/doczjs/docz/blob/master/core/gatsby-theme-docz/src/components/Props/index.js#L68
- Pass isToggle down to Prop https://github.com/doczjs/docz/blob/master/core/gatsby-theme-docz/src/components/Props/index.js#L74
- Add isToggle argument in Prop definition : https://github.com/doczjs/docz/blob/master/core/gatsby-theme-docz/src/components/Props/index.js#L23
- Initialize showing state to isToggle https://github.com/doczjs/docz/blob/master/core/gatsby-theme-docz/src/components/Props/index.js#L24
Syntactically looking good so far, thanks for your contribution!
|
Thanks @gogoyqj ! Will release an alpha and update here. |
|
Will be released as 2.3.0. Currently released as 2.3.0-alpha.4. You can try it with : |
|
with pleasure |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #1323
Screenshots