Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 30, 2018. It is now read-only.

Conversation

@kitsonk
Copy link
Member

@kitsonk kitsonk commented Dec 4, 2017

This PR provides a new LiveCodeController and LiveCodeExample which provides the ability to embed examples within a web page that are editable and runnable.

@kitsonk kitsonk requested a review from nicknisi December 4, 2017 19:38
@kitsonk
Copy link
Member Author

kitsonk commented Dec 4, 2017

Here is a video of it in action:

liveeditor

@codecov
Copy link

codecov bot commented Dec 4, 2017

Codecov Report

Merging #33 into master will increase coverage by 0.97%.
The diff coverage is 74.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #33      +/-   ##
=========================================
+ Coverage   66.53%   67.5%   +0.97%     
=========================================
  Files          17      29      +12     
  Lines        1007    1779     +772     
  Branches      239     418     +179     
=========================================
+ Hits          670    1201     +531     
- Misses        337     578     +241
Impacted Files Coverage Δ
src/widgets/Editor.ts 73.52% <100%> (ø)
src/widgets/LiveEditor.ts 100% <100%> (ø)
src/widgets/Runner.ts 97.65% <100%> (ø)
src/project.ts 75.77% <38.8%> (-11.56%) ⬇️
src/LiveCodeExample.ts 90.47% <90.47%> (ø)
src/LiveCodeController.ts 98.14% <98.14%> (ø)
src/widgets/ActionBar.ts 89.47% <0%> (ø)
src/widgets/IconCss.ts 100% <0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da1955f...6c4f126. Read the comment docs.

@dylans dylans added this to the beta.5 milestone Dec 22, 2017
@agubler agubler removed this from the beta.5 milestone Jan 4, 2018
Copy link
Member

@nicknisi nicknisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code looks good! We need to figure out how this can be used alongside the current export of this project or how we can change things to make them both work.

@kitsonk
Copy link
Member Author

kitsonk commented Jan 15, 2018

@nicknisi I think I will get time this week to re-base it and submit something. How we get it to work along side the other export, I will see if it is obvious when I rebase it, if not, well I will at least try to think of an approach.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants