Conversation
…platform-specific content filling to use them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 概述
This PR refactors the common utility functions by centralizing them in
common.jsand injecting them into the page's main world context. This eliminates code duplication across platform-specific files (CSDN, Juejin, WeChat) and improves maintainability.Related Issue / 关联 Issue
N/A
Type of Change / 更改类型
Changes Made / 更改内容
common.jsto export centralized utility functions (injectCommonUtils,injectUtils)injectCommonUtils()function that defineswindow.waitForandwindow.setInputValuein the page's main worldwaitForimplementation using MutationObserver for better performance and reliabilitysetInputValueto work with React/Vue frameworks using native setterswaitForfunction implementations fromcsdn.js,juejin.js, andwechat.jsinjectUtilsbefore content fillingImplementation Details / 实现细节
Key Changes / 主要更改:
common.js: Transformed from content filling logic to utility function provider
injectCommonUtils(): Injected into page main world, provideswindow.waitForandwindow.setInputValueinjectUtils(): Helper function to inject utils via Chrome scripting APIwaitFor(): Now uses MutationObserver with timeout instead of pollingsetInputValue(): Enhanced to trigger framework change detection using native settersPlatform files (csdn.js, juejin.js, wechat.js):
import { injectUtils } from './common.js'waitForimplementations (16-23 lines each)await injectUtils(chrome, tab.id)before executing content filling scriptswindow.waitForinstead of localwaitForTechnical Notes / 技术说明:
Testing / 测试
Testing Checklist / 测试清单
Manual Testing Steps / 手动测试步骤
Screenshots/Videos / 截图/视频
N/A
Reviewer Checklist / 审阅者清单
Additional Notes / 补充说明