Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 概述
This PR optimizes the Zhihu (知乎) sync functionality by refactoring the platform-specific implementation from inline code to a modular sync handler pattern. The main improvement is reducing the initial page load wait time from 3000ms to a more efficient approach using MutationObserver.
Related Issue / 关联 Issue
Close #143
Type of Change / 更改类型
Changes Made / 更改内容
src/background.jstosrc/platforms/zhihu.js(removed 108 lines, added 134 lines)syncZhihuContentfunction following the established platform sync handler patternImplementation Details / 实现细节
Key Changes / 主要更改:
background.jsto a dedicatedsyncZhihuContenthandler inzhihu.jssetTimeout(resolve, 3000)withMutationObserverinwaitForElementfunction, allowing dynamic detection of DOM elements instead of fixed waitinginjectUtilsto inject thewaitForhelper function into the page contextTechnical Notes / 技术说明:
fillZhihuContentfunction executes in theMAINworld context to access page DOM without restrictionsMutationObserverfor efficient element detection with configurable timeout fallbackDataTransferAPI and drag-drop events for better compatibilityTesting / 测试
Testing Checklist / 测试清单
Manual Testing Steps / 手动测试步骤
Screenshots/Videos / 截图/视频
N/A - Performance improvement, no visual changes
Reviewer Checklist / 审阅者清单
Additional Notes / 补充说明
The sync time optimization is achieved by eliminating unnecessary fixed wait times and using event-driven element detection. This makes the sync process faster and more reliable, as it proceeds immediately when elements become available rather than waiting for arbitrary timeouts.