Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 概述
This PR fixes CORS (Cross-Origin Resource Sharing) issues that were blocking avatar image display on Weibo and Sspai platforms, and adds support for today's headline (Toutiao) content synchronization. Additionally, it updates multiple platform authentication APIs to use more reliable endpoints.
Related Issue / 关联 Issue
Closes #159
Type of Change / 更改类型
Changes Made / 更改内容
declarativeNetRequestpermission to manifest for handling CORS requestshttps://*.sinaimg.cn/*(Weibo image CDN) to fix avatar displayhttps://cdnfile.sspai.com/*(Sspai CDN) to fix avatar displayloginUrlfield for Sspai platform configurationImplementation Details / 实现细节
Key Changes / 主要更改:
CORS Blocking Fix: Added Chrome's
declarativeNetRequestpermission which allows the extension to modify network request headers to bypass CORS restrictions for avatar images from third-party CDNs (Weibo's sinaimg.cn and Sspai's cdnfile.sspai.com).Toutiao Synchronization: Implemented a complete sync handler (
syncToutiaoContent) that properly handles Toutiao's ProseMirror-based rich text editor. The implementation includes:waitForElementfunction with MutationObserver for robust element detectionAPI Endpoint Updates: Migrated several platform authentication checks to more stable API endpoints that provide better reliability and richer user information (username + avatar).
Technical Notes / 技术说明:
declarativeNetRequestpermission is used instead ofwebRequestfor better performance and compatibility with Manifest V3document.execCommand('insertHTML')which is ProseMirror-compatibleTesting / 测试
Testing Checklist / 测试清单
Manual Testing Steps / 手动测试步骤
Screenshots/Videos / 截图/视频
N/A - This is primarily a backend/API fix. Visual changes are limited to previously broken avatars now displaying correctly.
Reviewer Checklist / 审阅者清单
Additional Notes / 补充说明
The
declarativeNetRequestpermission requires user approval during extension installation/update. Users will see a permission prompt indicating the extension can "Block content on any page" - this is standard Chrome permission language for this API and is necessary to fix the CORS avatar loading issue.