Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 概述
This PR refactors the build output directory structure by renaming
dist/src/todist/bundles/to better reflect the actual content (compiled bundles vs source code) and follow modern web development conventions.Related Issue / 关联 Issue
Close #161
Type of Change / 更改类型
Changes Made / 更改内容
vite.config.jsto output bundles tobundles/instead ofsrc/manifest.jsonto reference scripts frombundles/directorycli.tsbuild script to copy platform files tobundles/platforms/content.jsto load inject script frombundles/inject.jsImplementation Details / 实现细节
Key Changes / 主要更改:
vite.config.js - Changed Rollup output configuration:
entryFileNames:'src/[name].js'→'bundles/[name].js'chunkFileNames:'src/chunks/[name].js'→'bundles/chunks/[name].js'manifest.json - Updated all script references:
src/background.js→bundles/background.jssrc/content.js→bundles/content.jssrc/inject.js→bundles/inject.jssrc/platforms/*.js→bundles/platforms/*.jsscripts/cli.ts - Updated copy target for platform scripts:
dist/src/platforms→dist/bundles/platformssrc/content.js - Updated runtime URL for inject script:
chrome.runtime.getURL('src/inject.js')→chrome.runtime.getURL('bundles/inject.js')Technical Notes / 技术说明:
dist/bundles/for JavaScript bundles,dist/assets/for static assetsTesting / 测试
Testing Checklist / 测试清单
Manual Testing Steps / 手动测试步骤
pnpm buildto generate the new directory structuredist/bundles/instead ofdist/src/chrome://extensions(Developer mode → Load unpacked)Screenshots/Videos / 截图/视频
N/A - This is an internal directory structure refactoring with no visible UI changes.
Before:
After:
Reviewer Checklist / 审阅者清单
Additional Notes / 补充说明
This refactoring improves code clarity and follows naming conventions that better indicate the purpose of each directory:
bundles/- Compiled, bundled JavaScript ready for browser executionassets/- Static assets (icons, manifest, etc.)The change is non-breaking for end users as they only interact with the installed extension, not the build artifacts. However, any documentation or tooling that references the old
dist/src/path should be updated accordingly.