Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed InfoQ platform user detection by switching from the deprecated
/public/v1/my/menuendpoint (which returns 404) to the working/public/v1/user/get_userAPI endpoint.Related Issue
N/A
Type of Change
Changes Made
packages/detection/src/platforms/infoq.jsfile with detection logicdetectInfoQUserimport and registration inpackages/detection/src/detect.js/public/v1/user/get_userAPI endpointImplementation Details
Root Cause:
The original InfoQ detection used the
/public/v1/my/menuendpoint, which now returns 404 and is no longer available.Key Changes:
/public/v1/user/get_userendpoint withcredentials: 'include'to maintain session{}as required by the APIdataobjectnicknameandavatarfields for user identificationconvertAvatarToBase64utility when avatar is hosted on geekbang.org to bypass CORS restrictionsTechnical Notes:
code === 0and presence ofuidTesting
Testing Checklist
Manual Testing Steps
Screenshots/Videos
N/A
Additional Notes
This fix uses the current working API endpoint and follows the same pattern as other platform detectors in the codebase.