Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed OSChina platform detection to work with MV3 service workers by switching from HTML parsing to cookie-based authentication check with API fallback.
Related Issue
N/A
Type of Change
Changes Made
Implementation Details
Key Changes:
oscidcookie existencefetchwith HTML parsing tochrome.cookies.getAPI/oschinapi/user/myDetailsAPI call for username and avatar retrievalTechnical Notes:
documentor DOM APIs, requiring cookie-based approachTesting
Testing Checklist
Manual Testing Steps
Screenshots/Videos
N/A
Reviewer Checklist
Additional Notes
This fix addresses compatibility issues with Manifest V3 service workers where DOM-based operations are not available. The cookie-based approach is more maintainable and less prone to breakage from UI changes on OSChina's website.