Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the Cnblogs (博客园) platform detection logic by implementing a new API-based detection method.
Related Issue
N/A
Type of Change
Changes Made
cnblogsentry fromLOGIN_CHECK_CONFIGinconfigs.jsdetectCnblogsUserfunction inplatforms/cnblogs.jsdetectCnblogsUserintoPLATFORM_DETECTORSmap indetect.jsImplementation Details
Key Changes:
New Detection Strategy: Implemented a three-step detection process:
chrome.cookies.getAll()API (MV3 compatible)account.cnblogs.com/user/userinfowith cookies attached manuallyCookie Collection: Gather cookies from multiple domains (
.cnblogs.com,www.cnblogs.com,account.cnblogs.com) and deduplicate them to ensure proper authentication.Avatar Handling: Process avatar URLs by:
Technical Notes:
chrome.cookies.getAll()instead of DOM-based detection to ensure compatibility with MV3 service workersloggedIn,username, andavatarfields{ loggedIn: false }on any errorTesting
Testing Checklist
Manual Testing Steps
Screenshots/Videos
N/A
Reviewer Checklist
Additional Notes
This implementation replaces the previous Cnblogs detection logic with a more reliable API-based approach that is compatible with Chrome Manifest V3 service workers.