Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
ts()helper function toreload-extension.mjsthat returns the current local time inHH:MM:SS(24-hour) format. Allconsole.logstatements in the reload script now include this timestamp in their prefix, changing the format from[reload]to[reload HH:MM:SS].Related Issue
N/A
Type of Change
Changes Made
ts()helper function that returns the current time vianew Date().toLocaleTimeString('en-US', { hour12: false, hour: '2-digit', minute: '2-digit', second: '2-digit' })console.logcall prefixes inreload-extension.mjsfrom the static string[reload]to the dynamic template literal`[reload ${ts()}]`Implementation Details
Key Changes:
apps/extension/scripts/reload-extension.mjs: Addedts()function (lines 17-19) and updated 9console.logstatements to embed the timestampTechnical Notes:
ts()usestoLocaleTimeStringwith'en-US'locale andhour12: falseto ensure a consistentHH:MM:SSformat regardless of the system localeTesting
Testing Checklist
Manual Testing Steps
node apps/extension/scripts/reload-extension.mjs)distdirectory[reload HH:MM:SS]formatScreenshots/Videos
N/A
Reviewer Checklist
Additional Notes
This change improves the debuggability of the extension reload script by making it easy to correlate log output with specific reload events when the watcher has been running for an extended period.